Skip to content

Conversation

@billy1624
Copy link
Member

Changes

@billy1624 billy1624 self-assigned this Dec 6, 2022
@billy1624 billy1624 marked this pull request as ready for review December 6, 2022 12:30
@billy1624 billy1624 requested a review from ikrivosheev December 6, 2022 12:30
Copy link
Contributor

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billy1624 thank you! LGTM!

@ikrivosheev ikrivosheev merged commit 4ca4446 into SeaQL:master Dec 6, 2022
- uses: actions/checkout@v3

- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@master
Copy link
Contributor

@ikrivosheev ikrivosheev Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billy1624, sorry, was it mistake or expected that here is unstable rust compiler?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikrivosheev thanks for double checking! This is done intentionally :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants