Conversation
rkrasiuk
reviewed
Nov 13, 2022
rkrasiuk
left a comment
rkrasiuk
left a comment
There was a problem hiding this comment.
left some smol comments/suggestions
jferas
approved these changes
Nov 14, 2022
Contributor
jferas
left a comment
jferas
left a comment
There was a problem hiding this comment.
Looks good.. and losing the line number for now doesn't seem like a major issue as the offending string is output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hacky regex checks with solang, which is a solidity parser. One downside is that we currently lose line number info, but we can get it back in a future update. solang provides location data as start and end offsets in bytes, so we have to manually convert that to line number by mapping it to the input string.
Edit: foundry has the function we need to do that implemented here, so we can use that to report line numbers, h/t/ @rkrasiuk