Skip to content

feat: update deps, allow RevertGiven, stricter test naming checks#33

Merged
mds1 merged 6 commits intomainfrom
feat/RevertGiven
Sep 5, 2023
Merged

feat: update deps, allow RevertGiven, stricter test naming checks#33
mds1 merged 6 commits intomainfrom
feat/RevertGiven

Conversation

@mds1
Copy link
Contributor

@mds1 mds1 commented Sep 1, 2023

Closes #32.

  • Updates dependencies
  • Allows RevertGiven as an additional allowed name
  • Parses test names by splitting them at underscores to be stricter about disallowing certain names. This is required because the regex crate does not support Îlook-aheads, which are required to restrict things like test_RevertIfCondition

@PaulRBerg would love if you could give this a test

Copy link

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the two comments below.

Thanks for this

@mds1 mds1 merged commit 76c8f01 into main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand the scope of the naming convention regex

3 participants