fix(scoop-download|install|update): Use consistent options #5956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix a bug: the shorthand of the option--no-hash-checkfor the commandscoop downloadshould be-sinstead of-hto be consistent withscoop installandscoop update, since the flag-halways means printing help text for a command.BTW, the option--no-hash-checkforscoop downloadis also inconsistent with--skipforscoop installorscoop update, even though they work the same way. For backwards compatibility, I did not adjust it. Should we?EDITED: Use consistent options (
-s/--skip-hash-check) forscoop download,scoop installandscoop update.How Has This Been Tested?
- Runscoop download -h, and it prints the help text for us.- Runscoop download -s <app>, and it skips the hash verification after the download, which is the expected behavior.Run the following to check available CLI options in the help text:
scoop download -hscoop install -hscoop update -hRun the following to skip hash validation:
scoop download -s <app>scoop download --skip-hash-check <app>scoop install -s <app>scoop install --skip-hash-check <app>scoop update -s <app>scoop update --skip-hash-check <app>Checklist:
developbranch.