feat(core): New cache filename format #5929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chawye Hsu <[email protected]>
Signed-off-by: Chawye Hsu <[email protected]>
Signed-off-by: Chawye Hsu <[email protected]>
niheaven
reviewed
Apr 29, 2024
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Co-authored-by: Hsiao-nan Cheung <[email protected]>
|
I have no idea how frequently our users clean and rebuid their caches, but the max extended support period I would do would be 1 year. It is however just an expectation and it may be there for a much longer time - we may forget to update it, most of the time ;) |
niheaven
approved these changes
Apr 29, 2024
ghost
mentioned this pull request
5 tasks
brian6932
pushed a commit
to brian6932/Scoop
that referenced
this pull request
Jun 1, 2024
Signed-off-by: Chawye Hsu <[email protected]> Co-authored-by: Hsiao-nan Cheung <[email protected]>
brian6932
pushed a commit
to brian6932/Scoop
that referenced
this pull request
Jun 1, 2024
Signed-off-by: Chawye Hsu <[email protected]> Co-authored-by: Hsiao-nan Cheung <[email protected]>
niheaven
added a commit
that referenced
this pull request
Jun 30, 2024
Signed-off-by: Chawye Hsu <[email protected]> Co-authored-by: Hsiao-nan Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces #4349, with sha1 for shorter output. For a better migration experience and implicit bandwidth saving, old cache files will still be used when available but this check may be removed sometime in the future.
Motivation and Context
Fixes #4327
Closes #4349
How Has This Been Tested?
unit tests added
Checklist:
developbranch.