Skip to content

Conversation

@bjlittle
Copy link
Member

@bjlittle bjlittle commented May 27, 2018

Companion PR of SciTools/iris#3019.

Most of the image differences from mpl version 1.5.3 to 2.2.2 are due to standard changes in

  • font
  • ticks
  • axes margins
  • contouring levels
  • colormap etc

See this gist on how image differences might affect the perceptual image hash.

However, there were some plots where our images using 1.5.3 were just wrong, particularly when plotting the values of grid_longitude, where the values used were deltas rather than values.

Also, time values are now being rendered correctly in some plots...various small minor changes that do make a difference.

@pp-mo
Copy link
Member

pp-mo commented May 30, 2018

@bjlittle there is no checking this stuff, you may as well self-merge.
I'd merge this, but don't have permissions.

@bjlittle
Copy link
Member Author

I'd rather not self-merge...

Let's see if I can sort out the permissions for you @pp-mo

@pp-mo pp-mo merged commit 0bdec9f into SciTools:gh-pages May 30, 2018
@bjlittle
Copy link
Member Author

Awesome, thanks @pp-mo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants