Non-Null Default SamplingPipeline#973
Conversation
- Made the `SamplingPipeline` default to a `DefaultSamplingPipeline`
|
To be honest I don't really get the design: I believe it's better to remove duplicating properties (like Temperature, etc) from This will also make overall usage more uniform: things you use in non-semantic-kernel environment could be transferred in a straightforward way and vise-versa E.g. SemanticKernel = What do you think? |
|
I didn't write the original semantic kernel integration so I may be wrong here, but from looking at it I think What you suggest sounds like a nicer API to use though, and you could certainly adapt the converter (https://github.com/SciSharp/LLamaSharp/blob/master/LLama.SemanticKernel/LLamaSharpPromptExecutionSettingsConverter.cs) to serialize the more complex object. Nobody is really "in charge" of developing the semantic kernel stuff at the moment, so PRs in this are are very welcome! |
SamplingPipelinedefault to aDefaultSamplingPipelineShould resolve #971