Merged
Conversation
- Built by this run: https://github.com/SciSharp/LLamaSharp/actions/runs/6921572568 - commit: `e937066420b79a757bf80e9836eb12b88420a218` - Rearranged paths
Collaborator
SanftMonster
left a comment
SanftMonster
left a comment
There was a problem hiding this comment.
Could you please also update the nuspec files to ensure the auto-release working? The only things need to be done is to append the paths of new libraries. :)
Member
Author
|
@AsakusaRinne I've updated the nuspec files and I think they build correctly. I haven't really worked with nuspec much before though so please look at those closely in your review! |
Collaborator
|
It looks good, I'll double-check the nuget package generation before next release. :) |
SanftMonster
approved these changes
Nov 20, 2023
Collaborator
|
@martindevans It looks good, and I pass all test locally with the binaries. |
This was referenced Nov 22, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new binaries.
e937066420b79a757bf80e9836eb12b88420a218