Skip to content

fix(Dynamic graphs): Fix text labels not updating when dynamically updated #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
altavir merged 1 commit into from
Nov 29, 2020
Merged

fix(Dynamic graphs): Fix text labels not updating when dynamically updated #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/src/main/kotlin/misc/dynamicBars.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ fun main() {
name to Bar {
x.strings = initialValue.map { "Column: $it" }
y.numbers = initialValue
textsList = initialValue.map { "Initial value of this datapoint is: ${it}"}
this.name = name
}
}
Expand Down Expand Up @@ -58,6 +59,7 @@ fun main() {
val yValues = bar.y.doubles
yValues[columnIndex] = Random.nextInt(0,100).toDouble()
bar.y.doubles = yValues
bar.textsList = yValues.map { "Updated value of this datapoint is: ${it}"}
}
}
}
Expand All @@ -68,4 +70,4 @@ fun main() {
readLine()

server.close()
}
}
6 changes: 5 additions & 1 deletion plotlykt-core/src/jsMain/kotlin/kscience/plotly/plotlyElement.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,15 @@ fun HTMLElement.plot(plot: Plot, plotlyConfig: PlotlyConfig = PlotlyConfig()) {
traceData.z = arrayOf(traceData.z)
}

if (trace.text.value != null) {
traceData.text = arrayOf(traceData.text)
}

PlotlyJs.restyle(this, traceData, arrayOf(index))
}
}
}

fun HTMLElement.plot(plotlyConfig: PlotlyConfig = PlotlyConfig(), plotBuilder: Plot.() -> Unit) {
plot(Plot().apply(plotBuilder), plotlyConfig)
}
}