Skip to content

Specialize Base.similar for VectorOfArray with multidimensional parent #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 22, 2024
Merged

Specialize Base.similar for VectorOfArray with multidimensional parent #359

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8b58d81
add `parent` and specialize `Base.similar`
jlchan Feb 21, 2024
6cf6d8f
add test
jlchan Feb 21, 2024
959d80e
formatting
jlchan Feb 21, 2024
859793e
Update src/vector_of_array.jl
jlchan Feb 21, 2024
a07264c
Update src/vector_of_array.jl
ChrisRackauckas Feb 21, 2024
1352de9
Update and rename test/upstream.jl to test/downstream/odesolve.jl
ChrisRackauckas Feb 21, 2024
44de083
Update runtests.jl
ChrisRackauckas Feb 21, 2024
17ce92a
Update Project.toml
ChrisRackauckas Feb 21, 2024
2dac21d
Update Project.toml
ChrisRackauckas Feb 21, 2024
43072c8
Update odesolve.jl
ChrisRackauckas Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions test/upstream.jl → test/downstream/odesolve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,14 @@ end
ArrayPartition(zeros(1), [0.75])),
(0.0, 1.0)),
Rodas5()).retcode == ReturnCode.Success

function rhs!(duu::VectorOfArray, uu::VectorOfArray, p, t)
du = parent(duu)
u = parent(uu)
du .= u
end

u = fill(SVector{2}(ones(2)), 2, 3)
ode = ODEProblem(rhs!, VectorOfArray(u), (0.0, 1.0))
sol = solve(ode, Tsit5())
@test SciMLBase.successful_retcode(sol)