Potentially fix dropped values in DI sparse diff#2655
Closed
ChrisRackauckas wants to merge 1 commit intomasterfrom
Closed
Potentially fix dropped values in DI sparse diff#2655ChrisRackauckas wants to merge 1 commit intomasterfrom
ChrisRackauckas wants to merge 1 commit intomasterfrom
Conversation
visr
reviewed
Apr 2, 2025
| !isnothing(jac_config) ? | ||
| convert.( | ||
| eltype(u), SparseMatrixColorings.sparsity_pattern(jac_config[1])) : | ||
| eltype(u), SparseMatrixColorings.sparsity_pattern(abs.(jac_config[1]) .+ abs.(f.mass_matrix)): |
Contributor
There was a problem hiding this comment.
Suggested change
| eltype(u), SparseMatrixColorings.sparsity_pattern(abs.(jac_config[1]) .+ abs.(f.mass_matrix)): | |
| eltype(u), SparseMatrixColorings.sparsity_pattern(abs.(jac_config[1]) .+ abs.(f.mass_matrix))): |
ERROR: LoadError: ParseError:
# Error @ OrdinaryDiffEqDifferentiation\vCvMi\src\derivative_utils.jl:771:17
spzeros(eltype(u), length(u), length(u))
elseif eltype(f.sparsity) == Bool
# └ ── Expected `)`
visr
reviewed
Apr 2, 2025
|
|
||
| if isnothing(f.sparsity) | ||
| !isnothing(jac_config) ? convert.(eltype(u), SparseMatrixColorings.sparsity_pattern(jac_config[1])) : | ||
| !isnothing(jac_config) ? convert.(eltype(u), SparseMatrixColorings.sparsity_pattern(abs.(jac_config[1]) .+ abs.(f.mass_matrix)) : |
Contributor
There was a problem hiding this comment.
Suggested change
| !isnothing(jac_config) ? convert.(eltype(u), SparseMatrixColorings.sparsity_pattern(abs.(jac_config[1]) .+ abs.(f.mass_matrix)) : | |
| !isnothing(jac_config) ? convert.(eltype(u), SparseMatrixColorings.sparsity_pattern(abs.(jac_config[1]) .+ abs.(f.mass_matrix))) : |
Contributor
|
This fix won't work, the key is to give the right sparsity pattern to DI from the start so that it is reflected in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.