Handle edge case values for abstol and span with ITP#749
Merged
oscardssmith merged 2 commits intoSciML:masterfrom Dec 19, 2025
Merged
Handle edge case values for abstol and span with ITP#749oscardssmith merged 2 commits intoSciML:masterfrom
oscardssmith merged 2 commits intoSciML:masterfrom
Conversation
Comment on lines
+103
to
+104
| n_h = exponent(span / (2 * ϵ)) | ||
| ϵ_s = ϵ * exp2(n_h) * exp2(n0) |
Member
There was a problem hiding this comment.
why isn't this still exp2(n_h+n0)? I would expect that to be faster.
Contributor
Author
|
The if/else ensure that |
Member
|
yeah this makes sense. It is somewhat annoying that this is parameterized a little bit inefficiently, but realistically this won't cost any real performance. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Allows ITP to handle very small
abstol(and in particularabstol=0.0) and very big intervals. This is required to use it in DiffEqBase.