Add Base.length methods for ViewAxis and ComponentAxis types#294
Merged
ChrisRackauckas merged 9 commits intoSciML:mainfrom Feb 10, 2025
Merged
Add Base.length methods for ViewAxis and ComponentAxis types#294ChrisRackauckas merged 9 commits intoSciML:mainfrom
Base.length methods for ViewAxis and ComponentAxis types#294ChrisRackauckas merged 9 commits intoSciML:mainfrom
Conversation
Contributor
|
This would be good to reduce the breakage from #249. I'm not sure how internal it was, but getting a ComponentIndex instead of an Int and a ViewAxis instead of a UnitRange seems pretty breaking. Perhaps it would make sense to add these as well:
|
Contributor
Author
|
@visr Sorry for the trouble. I've added a couple of methods that may fix your issue to this PR. Would you be able to try them out? |
visr
added a commit
to Deltares/Ribasim
that referenced
this pull request
Feb 7, 2025
Contributor
|
@dingraha thanks a lot, that fixes all the issues we noticed with v0.15.23! |
Contributor
Author
|
@ChrisRackauckas FYI this PR now fixes a couple of issues @visr had with their Ribasim code: Deltares/Ribasim#2044. |
ChrisRackauckas
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This PR just adds
Base.lengthmethods for theViewAxisandComponentIndextypes, which I find necessary in downstream packages.