Skip to content

No reshape piracy#194

Merged
jonniedie merged 2 commits intomasterfrom
no-reshape-piracy
Apr 1, 2023
Merged

No reshape piracy#194
jonniedie merged 2 commits intomasterfrom
no-reshape-piracy

Conversation

@jonniedie
Copy link
Collaborator

The method

Base.reshape(A::AbstractArray, axs::NTuple{N,<:CombinedAxis}) where {N} = reshape(A, _array_axis.(axs))

commits type piracy for empty tuples since () isa NTuple{N, <:CombinedAxis} where {N}. This was introduced to fight OffsetArrays' type piracy for `reshape. We're going to revert this and only make a method for the splatted version. If someone is hitting an issue related to #123, they need to take it up with OffsetArrays

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2023

Codecov Report

Merging #194 (043b04d) into master (ed42033) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   73.64%   73.49%   -0.15%     
==========================================
  Files          20       20              
  Lines         683      683              
==========================================
- Hits          503      502       -1     
- Misses        180      181       +1     
Impacted Files Coverage Δ
src/array_interface.jl 83.33% <ø> (-0.18%) ⬇️
src/componentarray.jl 81.25% <0.00%> (-0.64%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonniedie jonniedie merged commit a202b30 into master Apr 1, 2023
@jonniedie jonniedie deleted the no-reshape-piracy branch April 1, 2023 15:35
@visr visr mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants