Specify what is using in SpecialMatrices#12
Merged
ErikQQY merged 1 commit intoSciFracX:masterfrom Dec 27, 2022
JeffFessler:jf/using
Merged
Specify what is using in SpecialMatrices#12ErikQQY merged 1 commit intoSciFracX:masterfrom JeffFessler:jf/using
ErikQQY merged 1 commit intoSciFracX:masterfrom
JeffFessler:jf/using
Conversation
Contributor
Author
|
I just noticed that your sister package makes it specific already - thanks! |
Contributor
Author
|
Bump 🙂 |
Member
|
Hi there! Sorry for the late response, I've been very busy lately. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I am helping maintain
SpecialMatrices.jland we are making some possibly breaking changes over there and we wanted to make sure they won't break registered packages that depend on it. This is one of 2 such packages.It took a while to figure out what you are actually using here from SM.
I know it is pretty common to just drop a lot of
using XYZstatements in the main project file,but that approach makes it hard for others to know what specifically is being used here.
This PR simply makes it clear. Thanks.