Skip to content

@W-17701719@ Replace raml files with oas#420

Merged
vcua-mobify merged 7 commits intofeature/oasfrom
replace-raml-files-with-oas
Jun 18, 2025
Merged

@W-17701719@ Replace raml files with oas#420
vcua-mobify merged 7 commits intofeature/oasfrom
replace-raml-files-with-oas

Conversation

@vcua-mobify
Copy link
Contributor

@vcua-mobify vcua-mobify commented Jun 17, 2025

Follow up PR to #418

The main goal of this PR is to replace the RAML files that have been committed to this repo with OAS spec files recently downloaded from Anypoint Exchange.

This PR also contains a few small adjustments:

  • a fix for handling the fact that both -internal and -public OAS files are now downloaded from exchange.
  • a tweak to better handle how versions are appended to API names since ShopperBaskets is now ShopperBasketsV1
  • Follow up on comments from @W-18575180@ Generate node SDK from OAS #418. This is just cleaning up some comments

Reviewing this PR:

  • Of the over 5k files in this PR, almost everything is within the apis or stagingApis directory. In both, the raml files were deleted. In apis, OAS files were added in their place.
  • The only files modified not tied to apis or stagingApis are generate-oas.ts, utils.ts and config.ts

Testing the changes:
Note: Make sure you have the raml-toolkit changes from SalesforceCommerceCloud/raml-toolkit#233 compiled on your local

  1. Pull down this PR

  2. Run npm run updateApis - verify that OAS files are compared by oasdiff

  3. Run npm run renderTemplates - verify that there are no typescript errors in the generated codebase (renderTemplates will run tsc as part of its execution)

  4. cd to testIntegration and run npm run test:ci - this will do everything in step 3 + build the .tgz file + run the integration tests.

@vcua-mobify vcua-mobify marked this pull request as ready for review June 17, 2025 22:55
@vcua-mobify vcua-mobify requested a review from a team as a code owner June 17, 2025 22:55
@vcua-mobify vcua-mobify merged commit ae6ec3e into feature/oas Jun 18, 2025
5 of 7 checks passed
@vcua-mobify vcua-mobify deleted the replace-raml-files-with-oas branch June 18, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants