@W-18482690: allow unknown query params#196
Merged
unandyala merged 14 commits intofeature/oasfrom Jun 3, 2025
Merged
Conversation
Contributor
joeluong-sfcc
left a comment
joeluong-sfcc
left a comment
There was a problem hiding this comment.
Are we planning to create a follow up PR for the node SDK once the OAS work gets merged in?
Other than these points LGTM
unandyala
changed the title
Contributor
Author
yes |
joeluong-sfcc
approved these changes
Jun 3, 2025
Contributor
joeluong-sfcc
left a comment
joeluong-sfcc
left a comment
There was a problem hiding this comment.
LGTM, thanks for updating the conditional check
unandyala
changed the title
vcua-mobify
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes changes to allow unknown query parameters for the API call so that when a new query parameter is added in the API, we don't need a new release of the SDK
Note: API implemention holds the responsibility to validate the query params