Handle Shopper Context title change @W-12969581#120
Merged
Conversation
unandyala
reviewed
Apr 11, 2023
unandyala
reviewed
Apr 11, 2023
…ub.com/SalesforceCommerceCloud/commerce-sdk-isomorphic into tg/handle-shopper-context-title-change
unandyala
reviewed
Apr 11, 2023
joeluong-sfcc
approved these changes
Apr 12, 2023
bredmond-sf
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
How does these changes fix this?
In these changes, we overwrite the
nameproperty of theShopperContextAPI model returned by the RAML Toolkit. To make the name change work with the template generation, we had to pass theupdateNameparameter for the init method inApiModel(documentation) (for some reasonApiMetadataobject doesn't have this parameter in itsinitmethod) as false. This is a crucial part in this fix since our name overwrite wouldn't matter, raml-toolkit would change the name property on its own.Also some test cases are updated after the breaking changes in the API.