Skip to content

fix: Safely re-introduce timeline regrouping for PMP messages after sticky scroll fix#645

Open
Septicity wants to merge 1 commit intoSableClient:devfrom
Septicity:dev
Open

fix: Safely re-introduce timeline regrouping for PMP messages after sticky scroll fix#645
Septicity wants to merge 1 commit intoSableClient:devfrom
Septicity:dev

Conversation

@Septicity
Copy link
Copy Markdown
Contributor

Description

In this PR, I fixed the sticky scrolling issue by disabling the automatic timeline regroup for PMP messages, since this event repeatedly scrolled the user to the bottom of the page in encrypted rooms with many PMP messages.

However, this change did end up regressing the functionality of that fix: Albeit extremely irregularly, some PMP messages will fail to be grouped together or will otherwise not have their profile picture load.

To fix this, I've reintroduced the timeline regroup logic, but I've replaced the regroup function to a different room event that still provides a visual refresh without doing any scrolling.

As the previous PR hasn't made it to a public release yet, I'm not including a changeset, as it serves the same purpose as and would have ideally been included in the original PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

I used AI to quickly trace exactly what each event type does and format the new room.emit line. As opposed to the Timeline event from before, the LocalEchoUpdated event should refresh the timeline without any automatic scrolling. This should make sure that PMP messages are properly regrouped automatically, and my testing confirms this.

@Septicity Septicity requested review from 7w1 and hazre as code owners April 6, 2026 21:34
@7w1 7w1 added the internal label Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants