Skip to content

Fix: Add max height to state events#491

Merged
7w1 merged 5 commits intoSableClient:devfrom
nushea:Event-maxHeight
Mar 24, 2026
Merged

Fix: Add max height to state events#491
7w1 merged 5 commits intoSableClient:devfrom
nushea:Event-maxHeight

Conversation

@nushea
Copy link
Copy Markdown
Contributor

@nushea nushea commented Mar 23, 2026

Description

This PR wants to cap the height of an event to prevent one single event taking the entire screensize.

(before the PR)
image

(after the PR)
image

Fixes #

Type of change

prevents

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@nushea nushea requested review from 7w1 and hazre as code owners March 23, 2026 05:03
@nushea nushea changed the title Event max height Fix: Add max height to state events Mar 23, 2026
@dozro
Copy link
Copy Markdown
Contributor

dozro commented Mar 23, 2026

there are some merge conflicts :3

@nushea
Copy link
Copy Markdown
Contributor Author

nushea commented Mar 23, 2026

there are some merge conflicts :3

how even?? 😭😭😭

edit: unmerge-conflicted them, merge-friendshiped them

@dozro dozro requested review from Rosy-iso and dozro March 23, 2026 13:00
Copy link
Copy Markdown
Contributor

@dozro dozro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

however, is it supposed to hide the "change the display name", when both names are very long?

image

@dozro dozro enabled auto-merge March 23, 2026 13:22
@dozro dozro disabled auto-merge March 23, 2026 13:25
@nushea nushea marked this pull request as draft March 23, 2026 18:07
@nushea nushea marked this pull request as ready for review March 24, 2026 05:13
@nushea
Copy link
Copy Markdown
Contributor Author

nushea commented Mar 24, 2026

This is how it looks with this variant with the idea that if someone needs the entire change they will be able to see the diff through a modal as soon as that is completed aswell.
image
image

@7w1 7w1 added this pull request to the merge queue Mar 24, 2026
Merged via the queue into SableClient:dev with commit f5d9e4a Mar 24, 2026
9 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Mar 24, 2026
> [!IMPORTANT]
> Merging this PR will create a new release.

## Fixes

* Fix standard embed links not rendering.
([#506](#506) by @7w1)
* Added maximum height to state events
([#491](#491) by @nushea)
@nushea nushea deleted the Event-maxHeight branch March 24, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants