Fix nil token #1337
Merged
Fix nil token #1337
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some instances send params with a nil value for the token key, so the encoding 64 can not succeed This fixes bsc#
When the request has no token, there is no value to update the registration token with This fixes bsc#1244166
Add test to check method is not called when token is nil
digitaltom
reviewed
Jun 6, 2025
Member
|
I changed the label here to 2.23, because 2.22 is already released. Can you add a note to the changelog? |
rjschwei
approved these changes
Jun 6, 2025
digitaltom
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some requests do send the token key in the params without any value or with nil value
This fixes that case
How to test
Tests have been updated to reflect that, activate a product on BYOS mode and send the token with nil value
it should not raise any error and the public cloud registration code should not get updated (or the method called)
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Review
Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.