Skip to content

Conversation

@alexandrevicenzi
Copy link
Member

Run gofumpt to fix formatting.
Add a few extra lines to be more legible.

Run gofumpt to fix formatting.
Add a few extra lines to be more legible.

Signed-off-by: Alexandre Vicenzi <[email protected]>
@alexandrevicenzi
Copy link
Member Author

The code was inconsistent, I attempted to make it a bit more concise for my sanity.

Copy link
Collaborator

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd suggest two additional steps (can be made in a later PR):

  1. add the commit with the reformat to {README,contributing}.md mentioning the commit sha to omit it from blame
  2. add the formater to the CI

@alexandrevicenzi
Copy link
Member Author

@dcermak see my notes.

  1. I'm ok with it, but I'm not sure if I understand what you want exactly, just a code styling guideline for newer contributions?
  2. I have an upcoming PR with changes to the CI, and I plan to include gofumpt.

@alexandrevicenzi alexandrevicenzi merged commit 3e96ba5 into SUSE:master Sep 2, 2024
@dcermak
Copy link
Collaborator

dcermak commented Sep 3, 2024

@dcermak see my notes.

1. I'm ok with it, but I'm not sure if I understand what you want exactly, just a code styling guideline for newer contributions?

No, I meant to add something along the lines of:

Note that commit 89987cf is a commit that applies gofumpt. To omit it from git blame run git blame --ignore-rev 89987cf1ede28415d0fd2057184ea425ba29b509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants