Allow setting of SCC credentials via environment variables #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcermak
reviewed
Oct 5, 2023
dcermak
reviewed
Oct 5, 2023
dirkmueller
force-pushed
the
handle_envs
branch
2 times, most recently
from
ae7277c to
c68b26c
Compare
dcermak
reviewed
Oct 19, 2023
This avoids an unnecessary warning when using SCCcredentials that have a system_token
Co-authored-by: Dan Čermák <[email protected]>
Co-authored-by: Dan Čermák <[email protected]>
dirkmueller
force-pushed
the
handle_envs
branch
from
8d7b00f to
d2f9c7e
Compare
dcermak
approved these changes
Oct 26, 2023
Collaborator
dcermak
left a comment
dcermak
left a comment
There was a problem hiding this comment.
LGTM, I've added just a question and a few doc-nitpicks. Feel free to accept or ignore.
Co-authored-by: Dan Čermák <[email protected]>
Co-authored-by: Dan Čermák <[email protected]>
Co-authored-by: Dan Čermák <[email protected]>
Co-authored-by: Dan Čermák <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.