Various golangci-lint v2.1x warnings fixed

internal/logger.go

@@ -59,7 +59,7 @@ func getLogWritter(path string) (io.WriteCloser, error) {
 		}
 	}
 
-	_, err = lf.WriteString(fmt.Sprintf("container-suseconnect %s\n", Version))
+	_, err = fmt.Fprintf(lf, "container-suseconnect %s\n", Version)
 	if err != nil {
 		lf.Close()
 		return nil, err

internal/regionsrv/hostsfile_test.go

@@ -77,6 +77,9 @@ func TestUpdateHostsFileSuccessful(t *testing.T) {
 	defer os.Remove(hostsFile)
 
 	before, err := os.ReadFile(hostsFile)
+	if err != nil {
+		t.Fatalf("os.ReadFile failed with: %v", err)
+	}
 
 	err = UpdateHostsFile("test-hostname", "1.1.1.1")
 	if err != nil {

internal/regionsrv/server_test.go

@@ -49,7 +49,6 @@ func (ts *testServer) run() (err error) {
 
 		conn, err := ts.server.Accept()
 		if err != nil {
-			err = errors.New("could not accept connection")
 			break
 		}
 

internal/service_test.go

@@ -36,7 +36,7 @@ func testServiceOutput(
 
 	products, err := parseProducts(reader)
 	if err != nil {
-		t.Errorf(err.Error())
+		t.Error(err.Error())
 	}
 	if len(products) != 1 {
 		t.Fatalf("Unexpected number of products found. Got %d, expected %d", len(products), 1)
@@ -47,7 +47,7 @@ func testServiceOutput(
 
 	result := buf.String()
 	if result != expectedOutput {
-		t.Errorf(result)
+		t.Error(result)
 	}
 
 	file, err := os.Create("result.txt")
@@ -56,7 +56,7 @@ func testServiceOutput(
 	}
 	defer file.Close()
 
-	fmt.Fprintf(file, result)
+	fmt.Fprint(file, result)
 }
 
 func TestServiceOutputSLE12(t *testing.T) {

internal/setup_test.go

@@ -44,7 +44,7 @@ func shouldHaveLogged(t *testing.T, str string) {
 	}
 
 	// The logged string includes the timestamp, get rid of it.
-	re := regexp.MustCompile("^\\d{4}/\\d{2}/\\d{2} \\d{2}:\\d{2}:\\d{2}\\s")
+	re := regexp.MustCompile(`^\d{4}/\d{2}/\d{2} \d{2}:\d{2}:\d{2}\s`)
 	logStr := strings.TrimSpace(re.ReplaceAllString(original, ""))
 
 	if strings.TrimSpace(str) != logStr {

internal/suseconnect.go

@@ -42,11 +42,12 @@ func (data *SUSEConnectData) onLocationsNotFound() bool {
 }
 
 func (data *SUSEConnectData) setValues(key, value string) {
-	if key == "url" {
+	switch key {
+	case "url":
 		data.SccURL = value
-	} else if key == "insecure" {
+	case "insecure":
 		data.Insecure = value == "true"
-	} else {
+	default:
 		log.Printf("Warning: Unknown key '%v'", key)
 	}
 }