fix(mp21x/drivers/usb): missing opening parenthesis in USB_OTG_GCCFG_FSVMINUS_Msk#5
Closed
7086cmd wants to merge 1 commit intoSTMicroelectronics:mainfrom
Closed
fix(mp21x/drivers/usb): missing opening parenthesis in USB_OTG_GCCFG_FSVMINUS_Msk#57086cmd wants to merge 1 commit intoSTMicroelectronics:mainfrom
7086cmd wants to merge 1 commit intoSTMicroelectronics:mainfrom
Conversation
|
Dear User, |
There was a problem hiding this comment.
Pull request overview
Fixes a malformed USB_OTG_GCCFG_FSVMINUS_Msk macro definition by adding the missing opening parenthesis, removing a syntax error and avoiding precedence/parsing issues for tooling.
Changes:
- Corrected
USB_OTG_GCCFG_FSVMINUS_Mskto wrap the shift expression in parentheses across STM32MP2xx header variants. - Ensured the macro formatting matches adjacent
*_Mskdefinitions (e.g.,FSVPLUS_Msk).
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp215fxx_cm33.h | Fixes malformed USB_OTG_GCCFG_FSVMINUS_Msk macro by adding missing (. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp215fxx_ca35.h | Same macro fix for CA35 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp215dxx_cm33.h | Same macro fix for CM33 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp215dxx_ca35.h | Same macro fix for CA35 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp215cxx_cm33.h | Same macro fix for CM33 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp215cxx_ca35.h | Same macro fix for CA35 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp215axx_cm33.h | Same macro fix for CM33 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp215axx_ca35.h | Same macro fix for CA35 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp213fxx_cm33.h | Same macro fix for CM33 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp213fxx_ca35.h | Same macro fix for CA35 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp213dxx_cm33.h | Same macro fix for CM33 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp213dxx_ca35.h | Same macro fix for CA35 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp213cxx_cm33.h | Same macro fix for CM33 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp213cxx_ca35.h | Same macro fix for CA35 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp213axx_cm33.h | Same macro fix for CM33 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp213axx_ca35.h | Same macro fix for CA35 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp211fxx_cm33.h | Same macro fix for CM33 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp211fxx_ca35.h | Same macro fix for CA35 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp211dxx_cm33.h | Same macro fix for CM33 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp211dxx_ca35.h | Same macro fix for CA35 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp211cxx_cm33.h | Same macro fix for CM33 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp211cxx_ca35.h | Same macro fix for CA35 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp211axx_cm33.h | Same macro fix for CM33 header variant. |
| Drivers/CMSIS/Device/ST/STM32MP2xx/Include/stm32mp211axx_ca35.h | Same macro fix for CA35 header variant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a syntax error/precedence risk in the USB_OTG_GCCFG_FSVMINUS_Msk macro definition.
I don't know whether this code works without the left parentheses, but it breaks some automated code-generation tools and static analyzers that parse these header files. Ensuring the left parentheses may also guarantee the order of operations.
I am new to ST's MPUs, and I'm willing to help.
Changes:
#define USB_OTG_GCCFG_FSVMINUS_Msk 0x1UL << USB_OTG_GCCFG_FSVMINUS_Pos)#define USB_OTG_GCCFG_FSVMINUS_Msk (0x1UL << USB_OTG_GCCFG_FSVMINUS_Pos)