Add support to desktop navigation device#83
Merged
Conversation
3 tasks
waliid
reviewed
Dec 18, 2023
waliid
reviewed
Dec 18, 2023
Apply suggestions from code review Co-authored-by: Walid Kayhal <[email protected]>
waliid
approved these changes
Dec 19, 2023
defagos
reviewed
Jan 8, 2024
defagos
approved these changes
Jan 8, 2024
Co-authored-by: Samuel Défago <[email protected]>
(cherry picked from commit 8c8cbe7227a1c9af364ba67544dbaa7837d1fd69)
defagos
force-pushed
the
feature/desktop-device
branch
3 times, most recently
from
f838640 to
b0ebf9b
Compare
1 task
Member
|
Forced squash & merge. The CI currently has issues but tests run fine locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
desktopsupport fornavigation_device, according to SRGAnalytics-documentation (on all events: pageView, media events and events).Inspired by SRGSSR/pillarbox-apple#364.
Changes made
isMacCatalystAppandisiOSAppOnMaconNSProcessInfoto setdesktopvalue fornavigation_deviceproperty.