Skip to content

Update to Commanders Act version 5#76

Merged
defagos merged 30 commits intodevelopfrom
feature/62-update-to-tag-commander-v5
Sep 12, 2023
Merged

Update to Commanders Act version 5#76
defagos merged 30 commits intodevelopfrom
feature/62-update-to-tag-commander-v5

Conversation

@defagos
Copy link
Member

@defagos defagos commented Sep 5, 2023 •
edited by pyby
Loading

Pull request

Description

This PR updates Commanders Act SDK to version 5.

Changes made

  • Update implementation to use version 5.
  • Update configuration API to support source keys instead of container identifiers.
  • Update page view tracking API to add mandatory page type support.
  • Rename hidden event as event for consistency with Pillarbox.
  • Switch analytics configuration to SRG and new site name.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos requested review from pyby and waliid September 5, 2023 09:38
waliid
waliid approved these changes Sep 5, 2023
View reviewed changes
@pyby pyby linked an issue Sep 6, 2023 that may be closed by this pull request
Update to Commanders Act version 5 #62
Closed
27 tasks
@pyby pyby force-pushed the feature/62-update-to-tag-commander-v5 branch from f9dad2b to 0e10997 Compare September 9, 2023 14:58
@pyby pyby mentioned this pull request Sep 11, 2023
Merged
defagos and others added 18 commits September 11, 2023 18:00
@defagos @pyby
Update Tag Commander SDK to version 5
207a6a3
@defagos @pyby
Update Tag Commander implementation
b1cffb3
@defagos @pyby
Update brand name
73df6af
@defagos @pyby
Setup test identifier label consistently
0ecfeed
@defagos @pyby
Update integration documentation
7704fdc
@defagos @pyby
Fix demo app icon
1c90ced
@defagos @pyby
Improve documentation
d5ed60b
@defagos @pyby
Remove environments
38eab0b
@defagos @pyby
Use debug key in the demo
892ad7c
@defagos @pyby
Fix identity test compilation
77ffeec
@pyby
Update TagCommander to 5.2.1 with official SPM repository
3df88fa
@pyby
Fix demo warning
bf4b83c
@pyby
Update TagCommander to 5.2.2 and use TCServerSide no IDFA library
758fa26
@pyby
Add default labels for TCPageViewEvent and TCCustomEvent
71f2d08
@pyby
Fix default labels for TCPageViewEvent and all TCCustomEvent
2fba4ff 
Including Media tracking events
@pyby
Update TagCommander to 5.3.1 and rename hidden event name property to…
9033838 
… event_title

Overlap with the flatten payload and TC event name property
@pyby
Update to new hidden event specification
5f93ffb
@pyby
Update TagCommander to 5.3.2
cc92934
@pyby pyby force-pushed the feature/62-update-to-tag-commander-v5 branch from 610b696 to 7ab0afa Compare September 11, 2023 16:00
@defagos defagos merged commit 28b7243 into develop Sep 12, 2023
@defagos defagos deleted the feature/62-update-to-tag-commander-v5 branch September 12, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyby pyby pyby approved these changes

@waliid waliid waliid approved these changes

Assignees

@defagos defagos

@pyby pyby

@waliid waliid

Labels

enhancement

Projects

Pillarbox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to Commanders Act version 5

3 participants

@defagos @pyby @waliid