Add support for volume control and mute state toggling#962
Merged
MGaetan89 merged 2 commits into928-custom-castplayerfrom Mar 28, 2025
Merged
Add support for volume control and mute state toggling#962MGaetan89 merged 2 commits into928-custom-castplayerfrom
MGaetan89 merged 2 commits into928-custom-castplayerfrom
Conversation
Closed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Scaffold(modifier = Modifier.fillMaxSize()) { innerPadding -> | ||
| Box(modifier = Modifier.padding(innerPadding)) { | ||
| MainView(player = player, modifier = Modifier) | ||
| MainView(player) |
Check warning
Code scanning / Android Lint
Synthetic Accessor Warning
MGaetan89
force-pushed
the
935-volume-management
branch
from
931fafe to
c237481
Compare
Code Coverage
Files
|
Base automatically changed from
RemoteMediaClient_nullability
to
928-custom-castplayer
March 27, 2025 13:17
MGaetan89
force-pushed
the
935-volume-management
branch
from
c237481 to
226af09
Compare
StaehliJ
approved these changes
Mar 28, 2025
StaehliJ
pushed a commit
that referenced
this pull request
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This commit adds support for volume management (local and device volume), as well as toggling the muted state of the device.
Changes made
PillarboxCastPlayer.pillarbox-demo-castto add a mute button and volume slider..idea/codeStyles/Project.xml.Checklist