Skip to content

Refactoring PillarboxAnalyticsCollector#925

Merged
StaehliJ merged 9 commits into
mainfrom
refactoring-monitoring
Mar 13, 2025
Merged

Refactoring PillarboxAnalyticsCollector#925
StaehliJ merged 9 commits into
mainfrom
refactoring-monitoring

Conversation

@StaehliJ

@StaehliJ StaehliJ commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

Pull request

Description

The goal of this PR is to simplify PillarboxExoPlayer by creating PlaybackSessionManager and MetricsCollector into PillarboxAnalyticsCollector.

Changes made

  • Expose Session.getDeviceId used by the monitoring.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Mar 5, 2025 that may be closed by this pull request
@github-project-automation github-project-automation Bot moved this to ✏️ Draft in Pillarbox Mar 5, 2025
@StaehliJ StaehliJ requested a review from MGaetan89 March 5, 2025 13:23
@github-actions

github-actions Bot commented Mar 5, 2025

Copy link
Copy Markdown

Code Coverage

Overall Project 50.94% -0.74% 🟢
Files changed 70.88% 🟢

Module Coverage
:pillarbox-player 57.17% -1.47% 🟢
Files
Module File Coverage
:pillarbox-player Context.kt 100% 🟢
PlaybackSessionManager.kt 92.86% -3.5% 🟢
Monitoring.kt 88.4% 🟢
PillarboxExoPlayer.kt 71.09% -4.67% 🟢
PillarboxAnalyticsCollector.kt 68.82% -1.18% 🟢
MetricsCollector.kt 68.2% -27.85% 🟢
Session.kt 57.64% 🟢

@StaehliJ StaehliJ force-pushed the refactoring-monitoring branch from 2707cec to b894b00 Compare March 12, 2025 10:16
@MGaetan89

Copy link
Copy Markdown
Contributor

I just pushed some small changes in c914d67.
The rest looks good to me know 👍🏻

@MGaetan89 MGaetan89 moved this from ✏️ Draft to 🍿 Code Review in Pillarbox Mar 12, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Mar 13, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 13, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 025bce2 Mar 13, 2025
@StaehliJ StaehliJ deleted the refactoring-monitoring branch March 13, 2025 08:27
@github-project-automation github-project-automation Bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants