Skip to content

Remove deprecated DefaultHttpClient#761

Merged
StaehliJ merged 1 commit into
mainfrom
remove_DefaultHttpClient
Oct 23, 2024
Merged

Remove deprecated DefaultHttpClient#761
StaehliJ merged 1 commit into
mainfrom
remove_DefaultHttpClient

Conversation

@MGaetan89
Copy link
Copy Markdown
Contributor

@MGaetan89 MGaetan89 commented Oct 23, 2024

Pull request

Description

Remove the deprecated DefaultHttpClient. It doesn't seem to be used on SRG and SRF sides.

Changes made

  • Remove deprecated DefaultHttpClient.
  • Remove unused dependencies from pillarbox-core-business.
  • Explicitly add kotlinx-datetime to pillarbox-demo.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 requested a review from StaehliJ October 23, 2024 09:21
@MGaetan89 MGaetan89 self-assigned this Oct 23, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 23, 2024

Code Coverage

Overall Project 48.49% 🟢

There is no coverage information present for the Files changed

@StaehliJ StaehliJ added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 0ae1ba7 Oct 23, 2024
@StaehliJ StaehliJ deleted the remove_DefaultHttpClient branch October 23, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

@MGaetan89 MGaetan89

Labels

None yet

Projects

Pillarbox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MGaetan89 @StaehliJ