Skip to content

Move Monitoring configuration to pillarbox-core-business#743

Merged
MGaetan89 merged 2 commits into
mainfrom
738-monitoring-as-opt-in
Oct 10, 2024
Merged

Move Monitoring configuration to pillarbox-core-business#743
MGaetan89 merged 2 commits into
mainfrom
738-monitoring-as-opt-in

Conversation

@MGaetan89
Copy link
Copy Markdown
Contributor

@MGaetan89 MGaetan89 commented Oct 9, 2024

Pull request

Description

This PR makes Monitoring an opt-in feature.

Changes made

  • Change PillarboxExoPlayer to use NoOpMonitoringMessageHandler by default.
  • Change DefaultPillarbox to use RemoteMonitoringMessageHandler in debug, and LogcatMonitoringMessageHandler in release.
  • Configure Monitoring in PlayerModule.
  • Update pillarbox-core-business documentation.
  • Update pillarbox-player documentation.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Oct 9, 2024 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 9, 2024

Code Coverage

Overall Project 48% -0.15% 🟢
Files changed 6.38% 🟢

Module Coverage
:pillarbox-core-business 79.8% -0.84% 🟢
:pillarbox-player 57.68% 🟢
Files
Module File Coverage
:pillarbox-core-business DefaultPillarbox.kt 0% -29.14% 🟢
:pillarbox-player PillarboxExoPlayer.kt 80.15% 🟢

@MGaetan89 MGaetan89 added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 812ad17 Oct 10, 2024
@MGaetan89 MGaetan89 deleted the 738-monitoring-as-opt-in branch October 10, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Monitoring as opt-in

2 participants