Skip to content

Remove deprecated symbols#723

Merged
MGaetan89 merged 1 commit into
mainfrom
remove_deprecated_code
Sep 27, 2024
Merged

Remove deprecated symbols#723
MGaetan89 merged 1 commit into
mainfrom
remove_deprecated_code

Conversation

@MGaetan89
Copy link
Copy Markdown
Contributor

@MGaetan89 MGaetan89 commented Sep 25, 2024

Pull request

Description

This PR removes the deprecated symbols from the project. They are deprecated since at least the current version and have documented replacements available.

Changes made

  • Remove MediaItemUrn from pillarbox-core-business.
  • Remove Player.disableTextTrack() from pillarbox-player.
  • Remove Player.setDefaultTextTrack(Context) from pillarbox-player.
  • Remove Player.disableAudioTrack() from pillarbox-player.
  • Remove Player.setDefaultAudioTrack(Context) from pillarbox-player.
  • Remove Tracks.text from pillarbox-player.
  • Remove Tracks.audio from pillarbox-player.
  • Remove Tracks.video from pillarbox-player.

Note

The following deprecated symbols are still available in the project:

  • DefaultHttpClient from pillarbox-core-business: it is not yet deprecated in the current version.
  • Various methods in PillarboxMediaController: these are deprecated in AndroidX Media3. So we need to wait for their removal from that project first (partially coming in version 1.5.0).

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 self-assigned this Sep 25, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 25, 2024

Code Coverage

Overall Project 48.92% 🟢
Module Coverage
:pillarbox-core-business 80.4% 🟢
:pillarbox-player 58.39% 🟢
Files
Module File Coverage
:pillarbox-core-business SRGMediaItemBuilder.kt 97.22% 🟢
:pillarbox-player Tracks.kt 97.37% 🟢
PlayerTracks.kt 0% 🟢

@MGaetan89 MGaetan89 force-pushed the remove_deprecated_code branch from f81f9f2 to 5920d22 Compare September 27, 2024 21:20
@MGaetan89 MGaetan89 added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit e437a5a Sep 27, 2024
@MGaetan89 MGaetan89 deleted the remove_deprecated_code branch September 27, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants