Revisit media item tracker#717
Merged
Merged
Conversation
6 tasks
1 task
Code Coverage
Files
|
MGaetan89
reviewed
Sep 25, 2024
1 task
…arboxMediaPeriodTest.kt Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
…ker/AnalyticsMediaItemTracker.kt Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
MGaetan89
approved these changes
Sep 26, 2024
Contributor
MGaetan89
left a comment
There was a problem hiding this comment.
One small improvement to a comment, plus the last open comment in PillarboxMediaPeriodTest, then all good 👍🏻
…ker/AnalyticsMediaItemTracker.kt Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The goal of this PR is to split and remove PillarboxData into 2 custom tracks and revisit
MediaItemTracker.The
MediaItemTrackerhave been revisited with new behaviors. The stop reason and the position are no more send and start and stop are called when current item change only.Changes made
TRACK_TYPE_PILLARBOX_TRACKERS.TRACK_TYPE_PILLARBOX_BLOCKED.getMediaItemTrackerDataOrNull.Tracks.getBlockedTimeRangeOrNull.MutableMediaItemTrackerDatato setupMediaItemTrackerdata and MediaItemTracker factories.MediaItemTrackerProviderfromPillarboxExoPlayer, Tracker factory are store inMediaItemTrackerData.Analytics changes
Comscore tracker doesn't create a new session when the same item is repeated or reach end and then seek back. It's end only when the player is released or when the player start the next or previous item.
Checklist
mainbranch.