1124 move chapters and credits data into tracks#1135
Merged
StaehliJ merged 11 commits into928-custom-castplayerfrom Aug 13, 2025
Merged
1124 move chapters and credits data into tracks#1135StaehliJ merged 11 commits into928-custom-castplayerfrom
StaehliJ merged 11 commits into928-custom-castplayerfrom
Conversation
2 tasks
Code Coverage
Files
|
MGaetan89
reviewed
Aug 12, 2025
...rbox-player/src/main/java/ch/srgssr/pillarbox/player/analytics/PillarboxAnalyticsListener.kt
Outdated
Show resolved
Hide resolved
...rbox-player/src/main/java/ch/srgssr/pillarbox/player/analytics/PillarboxAnalyticsListener.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/asset/Asset.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/session/PillarboxSessionCommands.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/session/PillarboxSessionCommands.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/source/PillarboxMediaSource.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/source/PillarboxMetadataTrackGroup.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/PillarboxExoPlayer.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/PillarboxPlayer.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/test/java/ch/srgssr/pillarbox/player/PillarboxMediaPeriodTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Gaëtan Muller <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The goal of this PR is to move back the
ChapterandCreditsinto the player tracks. The benefit of that strategy is to make them immutable. The PR also add custom callback to notify user when they changed.Changes made
PillarboxMetadatathat store chapters, credits and blocked time rangesonPillarboxMetadataChangedtoPillarboxPlayer.ListenercurrentPillarboxMetadatatoPillarboxPlayercurrentCreditstoPillarboxPlayercurrentChapterstoPillarboxPlayercurrentBlockedTimeRangestoPillarboxPlayerPillarboxMediaSessionandPillarboxMediaControllerChecklist