Skip to content

1124 move chapters and credits data into tracks#1135

Merged
StaehliJ merged 11 commits into928-custom-castplayerfrom
1124-move-chapters-credits-into-tracks
Aug 13, 2025
Merged

1124 move chapters and credits data into tracks#1135
StaehliJ merged 11 commits into928-custom-castplayerfrom
1124-move-chapters-credits-into-tracks

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Aug 11, 2025

Pull request

Description

The goal of this PR is to move back the Chapter and Credits into the player tracks. The benefit of that strategy is to make them immutable. The PR also add custom callback to notify user when they changed.

Changes made

  • Introduce PillarboxMetadata that store chapters, credits and blocked time ranges
  • Add callback onPillarboxMetadataChanged to PillarboxPlayer.Listener
  • Add currentPillarboxMetadata to PillarboxPlayer
  • Add currentCredits to PillarboxPlayer
  • Add currentChapters to PillarboxPlayer
  • Add currentBlockedTimeRanges to PillarboxPlayer
  • Update PillarboxMediaSession and PillarboxMediaController

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Aug 11, 2025
@StaehliJ StaehliJ linked an issue Aug 11, 2025 that may be closed by this pull request
2 tasks
@github-actions
Copy link

github-actions bot commented Aug 11, 2025

Code Coverage

Overall Project 45.82% -2.43% 🟢
Files changed 26.94% 🟢

Module Coverage
:pillarbox-core-business 78% 🟢
:pillarbox-player 54.12% -5.06% 🟢
:pillarbox-cast 20.23% -0.18% 🟢
:pillarbox-cast-receiver 20.05% -0.15% 🟢
:pillarbox-ui 0.26% -0.51% 🟢
Files
Module File Coverage
:pillarbox-core-business DefaultMediaMetaDataProvider.kt 98.77% 🟢
SRGAssetLoader.kt 90.69% 🟢
:pillarbox-player PillarboxMetadataTrackGroup.kt 100% 🟢
Asset.kt 100% 🟢
BlockedTimeRangeTracker.kt 98.93% 🟢
PillarboxMediaMetaDataTracker.kt 97.85% -0.54% 🟢
PillarboxMetadata.kt 96.88% -3.13% 🟢
PillarboxMediaPeriod.kt 95.3% 🟢
Tracks.kt 90.24% 🟢
PillarboxMediaSource.kt 87.45% 🟢
PillarboxExoPlayer.kt 75.41% -0.5% 🟢
PillarboxEventLogger.kt 72.03% 🟢
PillarboxAnalyticsCollector.kt 70.53% 🟢
PlayerCallbackFlow.kt 63.93% -4.33% 🟢
Player.kt 35.07% 🟢
PillarboxPlayer.kt 4.31% -69.83% 🟢
PillarboxAnalyticsListener.kt 0% -14.29% 🟢
PillarboxSessionCommands.kt 0% -63.08% 🟢
PillarboxMediaController.kt 0% -15.48% 🟢
PillarboxMediaSession.kt 0% -16.1% 🟢
MediaSessionCallbackImpl.kt 0% -27.81% 🟢
:pillarbox-cast PillarboxCastPlayer.kt 1.07% -0.31% 🟢
:pillarbox-cast-receiver PillarboxCastReceiverPlayer.kt 0% -0.45% 🟢
:pillarbox-ui ComposablePlayer.kt 0% -2.28% 🟢

@StaehliJ StaehliJ requested a review from MGaetan89 August 11, 2025 13:46
@StaehliJ StaehliJ merged commit 09f72d9 into 928-custom-castplayer Aug 13, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Aug 13, 2025
@StaehliJ StaehliJ deleted the 1124-move-chapters-credits-into-tracks branch August 13, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Pillarbox metadata changes not called in onMediaMetadataChanged

2 participants