Take the repeat mode into consideration when defining the available commands#1059
Merged
MGaetan89 merged 1 commit into928-custom-castplayerfrom Jun 10, 2025
Conversation
bcef676 to
88d8ce5
Compare
Code Coverage
Files
|
StaehliJ
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR updates the implementation of
RemoteMediaClient.getAvailableCommands()to take the repeat mode into consideration when defining if theCOMMAND_SEEK_TO_PREVIOUSandCOMMAND_SEEK_TO_NEXTcommands are available.The implementation is based on: https://github.com/androidx/media/blob/ae9a2339679826f870690092509a135dffc0d7e4/libraries/common/src/main/java/androidx/media3/common/util/Util.java#L3557-L3585
Changes made
RemoteMediaClient.getAvailableCommands()to use the repeat mode to define available commands.PlayerBottomToolbarwhen buttons become (un)available.RemoteMediaClient.getMediaIdFromIndex(), since it holds little logic.Checklist