Add device volume management to PillarboxCastPlayer#1012
Merged
StaehliJ merged 3 commits into928-custom-castplayerfrom May 27, 2025
Merged
Add device volume management to PillarboxCastPlayer#1012StaehliJ merged 3 commits into928-custom-castplayerfrom
PillarboxCastPlayer#1012StaehliJ merged 3 commits into928-custom-castplayerfrom
Conversation
MGaetan89
commented
May 2, 2025
| private val DEVICE_INFO_REMOTE_EMPTY = DeviceInfo.Builder(DeviceInfo.PLAYBACK_TYPE_REMOTE).build() | ||
|
|
||
| /** | ||
| * @see androidx.media3.cast.CastPlayer.MAX_VOLUME |
Contributor
Author
There was a problem hiding this comment.
This is not yet in the released version of Media3. You can see the explanation here for now:
https://github.com/androidx/media/blob/bd24ec08d13d74f2aae417b85f4cb40092c13f7e/libraries/cast/src/main/java/androidx/media3/cast/CastPlayer.java#L100-L107
Code Coverage
Files
|
6e8da3f to
87d5d90
Compare
a7592b9 to
547570a
Compare
…eVolume`, `handleDecreaseDeviceVolume` and `handleSetDeviceMuted` to PillarboxCastPlayer These implementations are based on AndroidX Media3's implementations from androidx/media@405365c
1444ca3 to
cb2ab57
Compare
StaehliJ
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the following method in
PillarboxCastPlayer:handleSetDeviceVolume().handleIncreaseDeviceVolume().handleDecreaseDeviceVolume().handleSetDeviceMuted().These implementations are based on AndroidX Media3's implementations from androidx/media@405365c.
Changes made
CastSessionto handle to device volume instead of theRemoteMediaClient.MediaRouteSelectorto theViewModeland use the one provided by Cast if available.Checklist