Skip to content

Fix Detekt warnings in PillarboxCastPlayer#1011

Merged
MGaetan89 merged 2 commits into928-custom-castplayerfrom
fix_detekt_warnings
May 5, 2025
Merged

Fix Detekt warnings in PillarboxCastPlayer#1011
MGaetan89 merged 2 commits into928-custom-castplayerfrom
fix_detekt_warnings

Conversation

@MGaetan89
Copy link
Contributor

Pull request

Description

I've extracted the logic to define the supported commands in a dedicated method. This reduces the complexity of the getState() method, and makes it more readable.

Changes made

  • Extract the logic of the supported commands in a dedicated method.
  • Add missing documentation to PillarboxCastPlayer.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this May 2, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox May 2, 2025
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🚧 In Progress in Pillarbox May 2, 2025
@github-actions
Copy link

github-actions bot commented May 2, 2025

Code Coverage

Overall Project 49.42% -0.15% 🟢
Files changed 86.33% 🟢

Module Coverage
:pillarbox-player 57.35% 🟢
:pillarbox-cast 20.08% -1.74% 🟢
Files
Module File Coverage
:pillarbox-player StringUtil.kt 100% 🟢
:pillarbox-cast RemoteMediaClient.kt 87.6% -8.2% 🟢
PillarboxCastPlayer.kt 0.56% -0.62% 🟢

@MGaetan89 MGaetan89 requested a review from StaehliJ May 2, 2025 08:05
@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox May 2, 2025
@MGaetan89 MGaetan89 merged commit 3f66e8f into 928-custom-castplayer May 5, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the fix_detekt_warnings branch May 5, 2025 09:18
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants