Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds RV32M (integer multiply/divide) instruction support across the RTL and expands the verification suite to cover decoder/ALU behavior and an end-to-end program.
Changes:
- Add RV32M instruction IDs and decode support (MUL/MULH/MULHSU/MULHU/DIV/DIVU/REM/REMU).
- Implement RV32M operations in the ALU, including divide-by-zero and overflow handling.
- Extend unit tests and add a new factorial-based system test intended to exercise M-extension operations.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
rtl/include/instr_defines.vh |
Adds instruction ID constants for RV32M ops. |
rtl/core_modules/decoder.v |
Decodes funct7/funct3 combinations for RV32M R-type instructions. |
rtl/core_modules/alu.v |
Implements RV32M multiply/divide/remainder semantics and adds a FORMAL vs non-FORMAL split. |
tests/unit_tests/test_decoder_gcc.py |
Updates assembler march to include m and adds decoder test vectors for RV32M instructions; adjusts sim env. |
tests/unit_tests/test_alu.py |
Adds RV32M ALU unit tests (including div-by-zero and overflow) and adjusts sim env. |
tests/system_tests/test_fibonacci.py |
Adds additional runtime logging in the simulation loop. |
tests/system_tests/test_factorial.py |
Adds new system test that compiles/runs factorial.c and monitors memory-mapped outputs. |
sim/factorial.c |
Adds factorial program intended to exercise all RV32M operations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sim/factorial.csystem test that exercises all M-extension operations, with volatile operands to prevent GCC from constant-folding them at -O1