Skip to content

Make comparisons not ambiguous (fixes clang warnings) #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Make comparisons not ambiguous (fixes clang warnings) #1703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions libopenage/coord/coord.h.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,8 @@ struct Coord${camelcase}Absolute {
return static_cast<Absolute &>(*this);
}

constexpr bool operator ==(const Absolute &other) const {
return ${formatted_members("(this->{0} == other.{0})", join_with=" && ")};
}

constexpr bool operator !=(const Absolute &other) const {
return !(*this == other);
friend constexpr bool operator ==(const Absolute &lhs, const Absolute &rhs) {
return ${formatted_members("(lhs.{0} == rhs.{0})", join_with=" && ")};
}
};

Expand Down Expand Up @@ -167,12 +163,8 @@ struct Coord${camelcase}Relative {
return static_cast<Relative &>(*this);
}

constexpr bool operator ==(const Relative &other) const {
return ${formatted_members("(this->{0} == other.{0})", join_with=" && ")};
}

constexpr bool operator !=(const Relative &other) const {
return !(*this == other);
friend constexpr bool operator ==(const Relative &lhs, const Relative &rhs) {
return ${formatted_members("(lhs.{0} == rhs.{0})", join_with=" && ")};
}
};

Expand Down
Loading