Skip to content

Make component classes final #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Make component classes final #1687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libopenage/gamestate/component/api/idle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2021-2023 the openage authors. See copying.md for legal info.
// Copyright 2021-2024 the openage authors. See copying.md for legal info.

#pragma once

Expand All @@ -7,7 +7,7 @@

namespace openage::gamestate::component {

class Idle : public APIComponent {
class Idle final : public APIComponent {
public:
using APIComponent::APIComponent;

Expand Down
2 changes: 1 addition & 1 deletion libopenage/gamestate/component/api/live.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@


namespace openage::gamestate::component {
class Live : public APIComponent {
class Live final : public APIComponent {
public:
using APIComponent::APIComponent;

Expand Down
4 changes: 2 additions & 2 deletions libopenage/gamestate/component/api/move.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2021-2023 the openage authors. See copying.md for legal info.
// Copyright 2021-2024 the openage authors. See copying.md for legal info.

#pragma once

Expand All @@ -8,7 +8,7 @@

namespace openage::gamestate::component {

class Move : public APIComponent {
class Move final : public APIComponent {
public:
using APIComponent::APIComponent;

Expand Down
4 changes: 2 additions & 2 deletions libopenage/gamestate/component/api/selectable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2023-2023 the openage authors. See copying.md for legal info.
// Copyright 2023-2024 the openage authors. See copying.md for legal info.

#pragma once

Expand All @@ -10,7 +10,7 @@

namespace openage::gamestate::component {

class Selectable : public APIComponent {
class Selectable final : public APIComponent {
public:
using APIComponent::APIComponent;

Expand Down
4 changes: 2 additions & 2 deletions libopenage/gamestate/component/api/turn.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2021-2023 the openage authors. See copying.md for legal info.
// Copyright 2021-2024 the openage authors. See copying.md for legal info.

#pragma once

Expand All @@ -10,7 +10,7 @@

namespace openage::gamestate::component {

class Turn : public APIComponent {
class Turn final : public APIComponent {
public:
using APIComponent::APIComponent;

Expand Down
2 changes: 1 addition & 1 deletion libopenage/gamestate/component/internal/activity.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Node;

namespace component {

class Activity : public InternalComponent {
class Activity final : public InternalComponent {
public:
/**
* Creates a new activity component.
Expand Down
4 changes: 2 additions & 2 deletions libopenage/gamestate/component/internal/command_queue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2021-2023 the openage authors. See copying.md for legal info.
// Copyright 2021-2024 the openage authors. See copying.md for legal info.

#pragma once

Expand All @@ -19,7 +19,7 @@ class EventLoop;

namespace gamestate::component {

class CommandQueue : public InternalComponent {
class CommandQueue final : public InternalComponent {
public:
/**
* Creates an Ownership component.
Expand Down
2 changes: 1 addition & 1 deletion libopenage/gamestate/component/internal/ownership.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class EventLoop;

namespace gamestate::component {

class Ownership : public InternalComponent {
class Ownership final : public InternalComponent {
public:
/**
* Creates an Ownership component.
Expand Down
2 changes: 1 addition & 1 deletion libopenage/gamestate/component/internal/position.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class EventLoop;

namespace gamestate::component {

class Position : public InternalComponent {
class Position final : public InternalComponent {
public:
/**
* Create a Position component.
Expand Down