Remove string splits with \r from renderer resource parsers
#1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
improvement
TheJJ
reviewed
Aug 4, 2024
| /** | ||
| * Newline splitter that works with both \n and \r\n. | ||
| */ | ||
| std::vector<std::string> split_newline(const std::string &txt); |
There was a problem hiding this comment.
could be returning std::string_views instead :)
There was a problem hiding this comment.
I tried, but it is creating so many problems with existing code that relies on std::string which also makes the code harder to read :/
For example, std::stoul won't accept a string view as an argument, so you have this confusing back and forth conversion between std::string_view and std::string in the renderer parsers...
TheJJ
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new dedicated
util::split_newlinefunction that can handle safe splits.