Fix error on engine modpack load
#1574
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
area: simulation
TheJJ
reviewed
Oct 12, 2023
|
|
||
|
|
||
| CURRENT_API_VERSION = "0.4.0" | ||
| CURRENT_API_VERSION = "0.5.1" |
Member
There was a problem hiding this comment.
we should import the global version id here, no?
Member
Author
There was a problem hiding this comment.
This was more of a test because I thought the API modpack might have been wrongly generated and caused the error in #1569 . But this was probably not the issue.
I don't think the modpack version should be bumped with every engine release btw. but maybe if there's a new version of the engine modpack, it should have the same version no as the current engine version.
Member
Author
There was a problem hiding this comment.
i might close this PR and think of something else to fix the issue
| mod_def = modpack.get_info() | ||
|
|
||
| mod_def.set_info("engine", "0.4.0", repo="openage") | ||
| mod_def.set_info("engine", "0.5.1", versionstr="0.4.0", repo="openage") |
Member
There was a problem hiding this comment.
here as well. should be a single source of truth?
Merged
Member
Author
|
Supreceded by #1574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1569