Use clang-format on entire code base
#120
Conversation
heinezen
added
improvement
|
pls rebase. and we should sync the openage clang-format config to the nyan repo while we're at it :) |
heinezen
force-pushed
the
fix/code-format
branch
from
6a99cdf to
2cd2653
Compare
done |
TheJJ
left a comment
TheJJ
left a comment
There was a problem hiding this comment.
hmm, before we push this, we should have another attempt to tame the formatting more. some formatting is now worse than before.
| std::ostringstream builder; | ||
| builder << msg << ": " | ||
| << token_type_str(token.get_type()); | ||
| << token_type_str(token.get_type()); |
There was a problem hiding this comment.
hm this is incorrect now - i thought clang-format was able to mix indentation and alignment?
There was a problem hiding this comment.
Isn't that because << is technically a line continuation? The documentation says:
UT_AlignWithSpaces(in configuration:AlignWithSpaces) Use tabs for line continuation and indentation, and spaces for alignment.
There was a problem hiding this comment.
it's a line continuation that should align to the previous <<. i thought we found a solution for this already to format correctly.
https://clang.llvm.org/docs/ClangFormatStyleOptions.html#alignoperands
but it seems to be weird anyway, even with always-tab (which we don't have):
llvm/llvm-project#59797
heinezen
force-pushed
the
fix/code-format
branch
from
2cd2653 to
1fd77e7
Compare
TheJJ
left a comment
TheJJ
left a comment
There was a problem hiding this comment.
the stream operation continuations are now non-aligned, but i can live with it.
the function chain calls are really messed up though. i've created llvm/llvm-project#114538 because this seems like a bug in clang-format.
we should manually fix them, it's not many places it seems.
|
Should I revert the changes that you mentioned for now? I don't think clang will solve them very soon. We can wrap these code parts in |
|
yea that may be a workaround until there's a fix |
heinezen
force-pushed
the
fix/code-format
branch
from
1fd77e7 to
baaf371
Compare
heinezen
force-pushed
the
fix/code-format
branch
from
baaf371 to
23a9304
Compare
|
I did a few ther changes to avoid having to use |
|
great, good to go now! |
2 participants
We use a
.clang-formatfile for our code style but most code in the repo does not adhere to this style. This PR changes that.Depends on #119