Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

fix: Error handling by CreateCourseView and CreateProjectView respectively #480

Open
bsilkyn wants to merge 3 commits into
base: development
Choose a base branch
from
Open

fix: Error handling by CreateCourseView and CreateProjectView respectively #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3281f5c
chore: creation of courses and projects through their respective view…
bsilkyn May 24, 2024
483202e
fix: hopefully fix for cypress tests; new chrome version
bsilkyn May 24, 2024
bf44115
fix: hopefully fix for cypress tests: new chrome version
bsilkyn May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/Dockerfile.cypress
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG CHROME_VERSION="114.0.5735.133-1"
ARG CHROME_VERSION="114.0.5735.198-1"
ARG NODE_VERSION="18.17.1"

FROM cypress/factory
5 changes: 3 additions & 2 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions frontend/src/views/courses/CreateCourseView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { useMessagesStore } from '@/store/messages.store.ts';

/* Composable injections */
const { t } = useI18n();
const { addSuccessMessage } = useMessagesStore();
const { addSuccessMessage, addErrorMessage } = useMessagesStore();
const { push } = useRouter();
const { faculties, getFaculties } = useFaculty();
const { createCourse } = useCourses();
Expand All @@ -28,11 +28,11 @@ const loading = ref(true);
*/
async function saveCourse(course: Course): Promise<void> {
try {
await createCourse(course);
await createCourse(course, false);
addSuccessMessage(t('toasts.messages.success'), t('toasts.messages.courses.create.success', [course.name]));
await push({ name: 'dashboard' });
} catch (error: any) {
// TODO error message
addErrorMessage(t('toasts.messages.error'), t('toasts.messages.courses.create.error', [course.name]));
}
}

Expand Down
8 changes: 4 additions & 4 deletions frontend/src/views/projects/CreateProjectView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ const loading = ref(true);
async function saveProject(newProject: Project, numberOfGroups: number): Promise<void> {
try {
if (course.value !== null) {
await createProject(newProject, course.value.id, numberOfGroups);
await createProject(newProject, course.value.id, numberOfGroups, false);

if (project.value !== null) {
await setStructureChecks(newProject.structure_checks ?? [], project.value.id);
await setExtraChecks(newProject.extra_checks ?? [], project.value.id);
await setStructureChecks(newProject.structure_checks ?? [], project.value.id, false);
await setExtraChecks(newProject.extra_checks ?? [], project.value.id, false);
addSuccessMessage(
t('toasts.messages.success'),
t('toasts.messages.projects.create.success', [project.value?.name]),
Expand All @@ -60,7 +60,7 @@ async function saveProject(newProject: Project, numberOfGroups: number): Promise
}
}
} catch (error: any) {
processError(error);
addErrorMessage(t('toasts.messages.error'), t('toasts.messages.projects.create.error', [project.value?.name]));
}
}

Expand Down