Skip to content

[Frontend] - integrate new tasks submissions in assignment overview - #588

Merged
thomasdejaeghere merged 24 commits into
developmentfrom
587-frontend---integrate-new-tasks-submissions-in-assignment-overview
May 19, 2025
Merged

[Frontend] - integrate new tasks submissions in assignment overview#588
thomasdejaeghere merged 24 commits into
developmentfrom
587-frontend---integrate-new-tasks-submissions-in-assignment-overview

Conversation

@lennertdr

@lennertdr lennertdr commented May 17, 2025

Copy link
Copy Markdown
Contributor

TODO

  • assignment overview collects the tasks if there are any
  • creates tasks as defined
  • student can submit their answers correctly
  • Initialization mode to setup all assignment tasks during creation
  • delete assignments?
  • submit empty steps (steps without task)
  • teacher can see the submissions for each step
  • while we're at it, improve the ways to visit each step
  • fix multiple choice creation: select correct answer bug + mark question as ready
  • implement submission for each step seperately (awaiting backend)
  • patch submissions as correct or incorrect
assignment.flow.mp4

Student can see if submission is marked correct:

mark.mp4

closes #329 #330 #334

}

handleContents(content: Buffer | string): string {
// Als het al een string is, gewoon teruggeven

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will translate

}

private submissionsForCurrentStep() {
// If we could use the API call for each step seperately, we would not need this function

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function contains a bug, but it's awaiting the correct backend support

}

approveSubmission(submission: Submission) {
// TODO: fix when backend has implemented PATCH submission

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awaiting PATCH from backend

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are coming

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only deleted unused imports, but my linter automatically changed a bunch of whitespaces.

This also happened in other files like mini-user, student-dashboard, ...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved logic from page to component

@lennertdr
lennertdr requested review from bramcomyn and brentjan May 19, 2025 01:54
@lennertdr
lennertdr marked this pull request as ready for review May 19, 2025 01:56
@lennertdr lennertdr self-assigned this May 19, 2025
@lennertdr lennertdr added feature Large feature issue with a lot of sub issues frontend labels May 19, 2025

@brentjan brentjan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 Very nice work!

@thomasdejaeghere thomasdejaeghere left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@thomasdejaeghere
thomasdejaeghere merged commit 2da41e3 into development May 19, 2025
@thomasdejaeghere
thomasdejaeghere deleted the 587-frontend---integrate-new-tasks-submissions-in-assignment-overview branch May 19, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Large feature issue with a lot of sub issues frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] - Teacher assignment step [Frontend] - Student assignment step [Frontend] - Student assignment

3 participants