[Backend] - Endpoints Tasks - #582
Merged
lennertdr merged 9 commits intoMay 16, 2025
Merged
Conversation
thomasdejaeghere
requested review from
Adrien-VL,
bramcomyn,
brieromb and
lennertdr
May 16, 2025 15:09
Adrien-VL
approved these changes
May 16, 2025
…-within-assignment
…' of https://github.com/SELab-2/Dwengo-2 into 559-backend---endpoint-to-create-task-within-assignment
lennertdr
approved these changes
May 16, 2025
lennertdr
deleted the
559-backend---endpoint-to-create-task-within-assignment
branch
May 16, 2025 17:59
bramcomyn
approved these changes
May 16, 2025
bramcomyn
left a comment
bramcomyn
left a comment
Contributor
There was a problem hiding this comment.
No immediate feedback, but perhaps explain why some unit tests appear to have been deleted?
Comment on lines
-93
to
-100
| it('should navigate to correct learning path URL', () => { | ||
| component.path.hruid = 'xyz456'; | ||
| component.path.language = 'Test'; | ||
| fixture.detectChanges(); | ||
|
|
||
| const card = fixture.debugElement.query(By.css('mat-card')); | ||
| expect(card.attributes['ng-reflect-router-link']).toContain('/paths,xyz456,Test'); | ||
| }); |
Contributor
There was a problem hiding this comment.
Why was this test deleted?
Contributor
There was a problem hiding this comment.
it failed and will be changed later on
Comment on lines
-44
to
-48
| it('should have the text', () => { | ||
| const text = harness.fixture.nativeElement.querySelector('p'); | ||
| expect(text).toBeTruthy(); | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
Why was this test deleted?
Contributor
There was a problem hiding this comment.
Same reason, test failed, if we have the time we will look deeper into it
Contributor
There was a problem hiding this comment.
(see details of the last failing push)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@Adrien-VL I combined your written functionality with mine in this PR.