[Backend] - Teacher/Student id and User id difference fix - #520
Merged
Conversation
brieromb
requested review from
Adrien-VL,
LambrechtMaarten and
thomasdejaeghere
April 28, 2025 13:50
brieromb
changed the title
3 tasks
| return userTypeORM; | ||
| } | ||
|
|
||
| public toEntity(): User { |
Contributor
There was a problem hiding this comment.
Maybe it would be a good idea to remove the Student and Teacher Entity and only use the User entity. An example to why this could be a good idea can be seen in the following lines. The createn of the Student/Teacher entity is basically the same here.
LambrechtMaarten
approved these changes
Apr 29, 2025
thomasdejaeghere
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the Teacher and Student tables from the database, as well as the TeacherOfClass and StudentOfClass tables. That is now one table: UserOfClass.
Added a field
rolein User table.Changed all the queries that involved doing operations in the Student or Teacher tables.
Updated the drawio database scheme