[Backend] - Separate query to get assignments for a teacher - #511
Merged
Conversation
bramcomyn
reviewed
Apr 24, 2025
Comment on lines
78
to
91
| const assignmentsJoinResult = await datasource | ||
| .getRepository(StudentOfGroupTypeORM) | ||
| .createQueryBuilder() | ||
| .where("StudentOfGroupTypeORM.student = :id", { id: userId }) | ||
| .where("StudentOfGroupTypeORM.student = :id", { id: studentOrTeacherId }) | ||
| // Join StudentOfGroup | ||
| .leftJoinAndSelect("StudentOfGroupTypeORM.group", "group") // Last one is alias | ||
| // Join Group to AssignmentGroup | ||
| .leftJoinAndSelect("group.assignment", "assignment") | ||
| // Join Assignment to Class | ||
| .leftJoinAndSelect("assignment.class", "class") | ||
| .getMany(); | ||
|
|
||
| return assignmentsJoinResult.map(assignmentJoinResult => { | ||
| return assignmentJoinResult.group.assignment.toAssignmentEntity(); | ||
| }); |
Contributor
There was a problem hiding this comment.
I would put this in an else, but ok.
Contributor
Author
There was a problem hiding this comment.
I originally did that but the linter was complaining about it...
Contributor
Author
|
I tested it out by logging in as a teacher and going to my assignments on our application, and it worked. |
brieromb
marked this pull request as draft
April 29, 2025 12:48
bramcomyn
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a separate query to get assignments for a teacher.