[Backend] - Names for assignments

[brieromb]

made the change for names in assignments on another branch again, because I thought that I did something wrong in solving the many merge conflicts on the other branch.

[brieromb]

@thomasdejaeghere There are still some integration tests that fail, but it's difficult to see which ones fail because the output of the failing tests is removed from my terminal because there is so much output from all the tests after them. How can I properly this?

[bramcomyn]

@thomasdejaeghere There are still some integration tests that fail, but it's difficult to see which ones fail because the output of the failing tests is removed from my terminal because there is so much output from all the tests after them. How can I properly this?

You can always redirect output to a logfile

command > output.txt

after which you can view the output through tools like less

less output.txt

I would suggest pulling the latest changes from development onto your branch, as we wouldn't have merged the integration testing without all tests succeeding.

[bramcomyn]

Also @brieromb, you can just check the logs in the backend workflow, which also shows the failing tests. It might give you a first idea.

[bramcomyn]

And as a last comment so far, @brieromb, could it be that the integration tests fail because they were based on an assignment which doesn't have a name field? Could it be that this breaks the server? I feel like it would reasonably be your responsibility to update them.

[thomasdejaeghere]

And as a last comment so far, @brieromb, could it be that the integration tests fail because they were based on an assignment which doesn't have a name field? Could it be that this breaks the server? I feel like it would reasonably be your responsibility to update them.

Yes @bramcomyn I tested on @brieromb his branch and that is indeed the case, the assignment objects and comparison objects in tests need to be updated with the extra field.

[brieromb]

All tests now pass.

The problem did not lie in the tests, but elsewhere.

The problem was that in the data source create assignment code, there was a hard coded conversion, instead of the createTypeORM method. I looked over that hard coded conversion initially, so that was not updated with the extra name field. but now I changed that to use the provided method for this.