Skip to content

[Frontend] - Class members list and class join requests components - #437

Merged
brentjan merged 27 commits into
developmentfrom
382-383-class-members-invites
Apr 15, 2025
Merged

[Frontend] - Class members list and class join requests components#437
brentjan merged 27 commits into
developmentfrom
382-383-class-members-invites

Conversation

@brentjan

@brentjan brentjan commented Apr 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR closes #382 and #383 .

It implements the members list for a class and all the necessary components/services needed to support this functionality.
Summary of new things:

  • Members list on the page of a specific class
  • "Show class code" button and popup for a specific class
  • Pending requests list for a specific class only visible for the teacher where buttons for accepting/rejecting the request
  • Create a join request component on the classes page
Screencast.from.2025-04-14.13-53-58.webm

The class page now has a better layout:
image

Things yet TODO:

  • Fix old tests
  • Write new tests for all this
  • Have a better layout for the class page
  • Clean up code

brentjan and others added 21 commits April 6, 2025 13:06
@brentjan
chore: init class members list component
aef8601
@brentjan
Merge branch 'development' into 382-383-class-members-invites
97a8864
@brentjan
feat: implemented class member list
af6c22f
@brentjan
chore: commit before checkout
0a637c1
@brentjan
feat: start of join request components
5124c2c
@brentjan
chore: commit before checkout
2a06b98
@brentjan
feat: fillUsers service method
8f1a742
@brentjan
chore: commit before checkout
039debb
@brentjan
feat: implemented services for accepting and rejecting requests, aswe…
2f5f950 
…ll as buttons
@brentjan
Merge branch 'development' into 382-383-class-members-invites
5e3836e
@brentjan
fix: bugfix with mat-table @for directives
205e18e
@brentjan
feat: component for creating a join request, found possible bug in ba…
8a223a6 
…ckend and reported it
@brentjan
feat: started dialog popup
e94cb7e
@brentjan
feat: show class code done, but can't center div
db3d4d3
@bramcomyn
feat: helped Brent with centering a div
1fce389
@brentjan
fix: merge conflicts
7367181
@brentjan
feat: added authenticated header in class page
985f97b
@brentjan
chore: commit before checkout
2f524f1
@brentjan
fix: merge conflict
7b596c5
@brentjan
Merge branch 'development' into 382-383-class-members-invites
3f635f9
@brentjan
feat: finished members list and join requests
2eaa394
@brentjan brentjan added enhancement New feature or request frontend labels Apr 14, 2025
@brentjan brentjan added this to the Milestone 2 milestone Apr 14, 2025
@brentjan brentjan self-assigned this Apr 14, 2025
This was linked to issues Apr 14, 2025
[Frontend] - Implement components/pages for class members #382
Closed
[Frontend] - Implement components/pages for class invites #383
Closed
@brentjan

brentjan commented Apr 14, 2025

Copy link
Copy Markdown
Contributor Author

I can confirm that the teacher requests also work @thomasdejaeghere !
image

@brentjan
brentjan marked this pull request as ready for review April 14, 2025 17:09
@brentjan brentjan added feature Large feature issue with a lot of sub issues and removed enhancement New feature or request labels Apr 14, 2025
lennertdr
lennertdr approved these changes Apr 15, 2025
View reviewed changes

@lennertdr lennertdr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

rvdkeere
rvdkeere approved these changes Apr 15, 2025
View reviewed changes

@rvdkeere rvdkeere left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@brentjan
brentjan merged commit 92fc2c2 into development Apr 15, 2025
@rvdkeere
rvdkeere deleted the 382-383-class-members-invites branch April 15, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvdkeere rvdkeere rvdkeere approved these changes
@lennertdr lennertdr lennertdr approved these changes
@bramcomyn bramcomyn Awaiting requested review from bramcomyn

Assignees

@brentjan brentjan

Labels

feature Large feature issue with a lot of sub issues frontend

Projects

None yet

Milestone

Milestone 2

Development

Successfully merging this pull request may close these issues.

[Frontend] - Implement components/pages for class invites [Frontend] - Implement components/pages for class members

4 participants

@brentjan @rvdkeere @lennertdr @bramcomyn